Thread Links Date Links
Thread Prev Thread Next Thread Index Date Prev Date Next Date Index

Re: [802.3_4PPOE] darshan_04_0917.pdf - Comments 198, 269, 406

Hi George,

Thanks

See below.

Yair

 

From: George Zimmerman [mailto:george@xxxxxxxxxxxxxxxxxxxx]
Sent: Friday, September 8, 2017 7:17 AM
To: STDS-802-3-4PPOE@xxxxxxxxxxxxxxxxx
Subject: Re: [802.3_4PPOE] darshan_04_0917.pdf - Comments 198, 269, 406

 

EXTERNAL EMAIL

Yair –

First, my comments regarding Heath’s class probe only proposal apply here as well.  You are trying to define a specific optional behavior, but you are hiding the option by not calling that behavior out in the state diagram, and relying on an ‘implementation specific reset’ to jump out.  Now, you have two levels of reset (the top level diagram pse_reset, and the sism-level diagram pse_reset_pri/sec).  This should be called out as conditional arcs and an option variable rather than as a hidden option driven by a reset.  I know we disagree on that, so I won’t spend any more time on it.

 

Now, to the text.  There are some editorial problems that I see right away – easily fixed:

  • The text refers to alternative A and alternative B while the state diagrams refer to the primary alternative and the secondary alternative.  You should use the same nomenclature (primary and secondary) as the state diagrams.  (this is throughout the variable definitions)

Yair: Corrected. Thanks.

 

  • Additionally, all the references to “PSE state diagram” should be to the specific state diagram, which for most of your new stuff is a SISM diagram, not the top level PSE state diagram (145-13). For example “Primary Alternative dual-signature semi-independent PSE state diagram” for _pri signals.  This applies to the text and to the “TRUE” and “FALSE” definitions.  Yes, it’s a mouthful, but we need to be precise – especially with the many diagrams we have which interrelate, and a master pse_reset for figure 145-13 which could interrupt you straight out of the SISM diagrams.

Yair:

  1. All the references to state diagram in the definition body text include already reference to the state diagram Figure which is I guess what you meant.
  2. I didn’t make references to the state diagram in the TRUE and FALSE which is I believe not necessary. Look at all other parameters that we didn’t do it as well.

I’ll spend some time tomorrow and see if anything in the machines is broken.

Yair: OK thanks.

-george

 

 

From: Yair Darshan [mailto:YDarshan@xxxxxxxxxxxxx]
Sent: Thursday, September 07, 2017 10:28 AM
To: STDS-802-3-4PPOE@xxxxxxxxxxxxxxxxx
Subject: [802.3_4PPOE] darshan_04_0917.pdf - Comments 198, 269, 406

 

Hi all,

Please see attached.

I’ll appreciate your feedback.

Regards

Yair

 

Darshan Yair

Chief R&D Engineer

Analog Mixed Signal Group

Microsemi Corporation

 

1 Hanagar St., P.O. Box 7220
Neve Ne'eman Industrial Zone
Hod Hasharon 45421, Israel
Tel:  +972-9-775-5100, EXT 210.

Cell: +972-54-4893019
Fax: +972-9-775-5111

 

E-mail: <mailto:ydarshan@xxxxxxxxxxxxx>.