Re: [802.3_YANG] YANG editors please start using Yanglint.

Thread Links	Date Links
Thread Prev	Thread Next	Thread Index	Date Prev	Date Next	Date Index

Thread Links

Date Links

Thread Prev

To: STDS-802-3-YANG@xxxxxxxxxxxxxxxxx

Subject: Re: [802.3_YANG] YANG editors please start using Yanglint.

From: Don Fedyk <dfedyk@xxxxxxxx>

Date: Mon, 28 Sep 2020 09:02:07 -0400

Arc-authentication-results: i=1; mx.google.com; dkim=policy (weak key) header.i=@labn.net header.s=default header.b=KXmfaBkM; spf=pass (google.com: domain of dfedyk@xxxxxxxx designates 67.222.33.93 as permitted sender) smtp.mailfrom=dfedyk@xxxxxxxx

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-language:thread-index:mime-version:message-id:date:subject :in-reply-to:references:cc:to:from:dkim-signature; bh=oF04a07HotOV9/K+r1eW1Ah4V7mJpX9EIqOJYSHW/Rc=; b=WJfVJlaFUrgtgApxT6EzZvNYtV4JRdQAkRKhHSDpjBUWwBx6F6aOCbGNNwVraI74uO cZK2WznHqB6+9n32IKHjGrilCsdqv0gK/QfAeP2ylEyUjnM/fVwyQfcOXh6Mygqlnh4s 99mEnpDlPKJoqJXzzVreUwvczXgZ1vn27DpHUrI+iZLK13I8EfhtHCMcw3nw5TIAycmX L7EpkW9rW6qH+/iGHMpTMCCs76KS0C5knONG/nNmFfZtOv70D8XWlLO3uSwIoKoX/zyo /NhHm6rbKDoCAKaGKVOw+ifuyDN7P4zX85pPUsljRxL4GwUwxFwWiBHuddmYaUiCSsCs ZkZQ==

Arc-seal: i=1; a=rsa-sha256; t=1601298135; cv=none; d=google.com; s=arc-20160816; b=Sll+jAS9Pd7pOAp5R84plSjewMfsfzV04laf3pTw/AAt/k7uNOUxT6NFLJRTBq8igO 9NikathCoG6q1LewoWKSalICPQzxkJynA2czB3TXIdTQ5k/2DkGfJubXR/+RqkdWg8b6 W5wnjmIhpJ5fNX/7QLDkpBKtSlWO2HR/PBHxTuXe+aLmY0R8vsLrOyAhU+qVkX1vCRoV 16/I9/i4MfbJa1FPtefuGdrR449p32ff0+ciiU89UwSuzNRfIRWBu97pLIhQMT4B2wFR wRy+0mv0sCGKLA8b55tVxiIeURQFCEUWeUmV3yPwSTWlU5N8VaaL+VLeoMmh53TcxZtq dN2g==

Delivered-to: mhonarc@xxxxxxxxxxxxxxxx

Delivered-to: stds-802-3-yang@xxxxxxxxxxxxxxxxx

In-reply-to: <CAAMqZPt0F4zjmZQTuW-5qeYhmrxU9YFmGb0DnS0BS6H7Lf1ebg@mail.gmail.com>

List-help: <https://listserv.ieee.org/cgi-bin/wa?LIST=STDS-802-3-YANG>, <mailto:LISTSERV@LISTSERV.IEEE.ORG?body=INFO%20STDS-802-3-YANG>

List-owner: <mailto:STDS-802-3-YANG-request@LISTSERV.IEEE.ORG>

List-subscribe: <mailto:STDS-802-3-YANG-subscribe-request@LISTSERV.IEEE.ORG>

List-unsubscribe: <mailto:STDS-802-3-YANG-unsubscribe-request@LISTSERV.IEEE.ORG>

References: <009301d69364$cb60cde0$622269a0$@labn.net> <CAAMqZPt0F4zjmZQTuW-5qeYhmrxU9YFmGb0DnS0BS6H7Lf1ebg@mail.gmail.com>

Reply-to: Don Fedyk <dfedyk@xxxxxxxx>

Thread-index: AQIYnMDhdhNnAc9azHVY6RBQLqEChgHrd078qOqZt0A=

Hi Paul

I’m working with Scott on this,

Cheers

Don

From: Paul Congdon <paul.congdon@xxxxxxxxxx>
Sent: Sunday, September 27, 2020 10:05 AM
To: Don Fedyk <dfedyk@xxxxxxxx>
Cc: stds-802-yang@xxxxxxxxxxxxxxxxx; STDS-802-3-YANG@xxxxxxxxxxxxxxxxx
Subject: Re: YANG editors please start using Yanglint.

Maybe you could provide some scripts or examples in a tools folder of the repo or somewhere convenient?

On Fri, Sep 25, 2020, 10:53 AM Don Fedyk <dfedyk@xxxxxxxx> wrote:

Hi

I’ve been pushing for editors to run Yanglint. At the very least loading your YANG in Yanglint will run more checks than Pyang.
For example I’ve spent a non-trivial amount of time just trying to get Qcw yang to load cleanly.

> load iana-if-type
> load ieee802-dot1q-bridge
> load ieee802-dot1q-stream-filters-gates
> load ieee802-dot1q-preemption
> load ieee802-dot1q-psfp
> load ieee802-dot1q-sched
>

Most of this was related to prefixes and they are technically warnings. However I think we should address YANG warnings especially when the fix is easy.
There are also some exposed xpath logic errors. I’ve not even loaded data in the model yet.
I will provide detail in my comments but if you are editing YANG please consider familiarizing yourself with Yanglint.

Summary errors in Qcw
Obsolete should obsolete status in all elements of an obsoleted structure
Prefixes Missing in elements in Xpath statements
Wrong type used in Xpath - container used as operand.

Thanks
Don
To unsubscribe from the STDS-802-YANG list, click the following link: https://listserv.ieee.org/cgi-bin/wa?SUBED1=STDS-802-YANG&A=1

To unsubscribe from the STDS-802-3-YANG list, click the following link: https://listserv.ieee.org/cgi-bin/wa?SUBED1=STDS-802-3-YANG&A=1