Hossein, thanks for providing your contribution https://www.ieee802.org/3/dj/public/adhoc/COM/24_1001/shakiba_3dj_COM_02_241001.pdf.
I have a few technical comments:
- On slide 3 “ADC clip level is chosen so that clipping frequency is equal to the target error rate”
- The clipping noise can reach larger values than the quantization noise, although with lower probability, but it can lead to undesired effects. In my experience, gain control algorithms typically targets much lower probability of clipping (often using some “soft clipping” level as an additional guard band).
- I don’t see the effect of the clipping noise in the calculations on slide 5. The effect may or may not be negligible and may depend on the choice of clipping probability.
- I would suggest making the clipping probability a separate parameter. The initial value can be 2*specBER as currently used, but we should study the effect of choosing a lower probability and preferably choose something more safe.
- On slide 11 “There is a negligible difference in DER_DFE“ – this seems reasonable with ENOB=32, but with ENOB=6 I would expect to see a significant difference. Can you clarify?
And some editorial comments, assuming your code is considered for committing:
- In multiple places you have expressions with the pattern “index = find(min(vector_expression)==vector_expression)” and then use index(1) to find the (first) location of the minimum. This can be written in MATLAB using the syntax “[~, index] = min(vector_expression)”. The latter is somewhat faster to calculate, but more importantly it is easier to read and understand (especially when the vector_expression is long, as it is in your code). It also works with max(), and will result in index being a scalar so you don't have to take the first element. I would suggest changing the code to make use of this method.
- Please change quantizaion to quantization (in multiple places)
- On slide 7 you define a few variables initially which are aliases of either existing variables or fields in “param”. These variables are then used only once. This makes the code longer and harder to track. I suggest using the existing variables and fields instead.
</Adee>
-----Original Message-----
From: Kent Lusted2 <kentlusted@xxxxxxxx>
Sent: Monday, October 14, 2024 3:53 AM
To: STDS-802-3-B400G-ELEC@xxxxxxxxxxxxxxxxx
Subject: [802.3_B400G_ELEC] [802.3dj] Proposed agenda for 15 Oct COM ad hoc meeting
Colleagues,
The proposed agenda for the 15 Oct COM ad hoc is to review "Commit Request
4p6_5: Quantization Noise Feature". See:
https://www.ieee802.org/3/dj/public/adhoc/COM/index.html
Note the short duration. Most of the (short) meeting time will be dedicated to code review and Q&A. Use of the electrical email reflector is strongly encouraged.
I want to remind all teleconference meeting participants to review the following documents prior to participation in an IEEE 802.3 meeting
teleconference:
* IEEE SA patent policy
* IEEE SA Copyright Policy
* IEEE SA Participation Policy and Code of Ethics
All of these policies may be found at http://ieee802.org/3/policies.html
-Kent
COM Ad hoc Chair, IEEE P802.3dj Task Force
________________________________________________________________________
To unsubscribe from the STDS-802-3-B400G-ELEC list, click the following link: https://listserv.ieee.org/cgi-bin/wa?SUBED1=STDS-802-3-B400G-ELEC&A=1
To unsubscribe from the STDS-802-3-B400G-ELEC list, click the following link: https://listserv.ieee.org/cgi-bin/wa?SUBED1=STDS-802-3-B400G-ELEC&A=1